README.md: Correct onwriteend to onwrite #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitToTheHub
force-pushed
the
pr-readme-correct-onwriteend
branch
from
4cd220c to
aa6e1e9
Compare
- FileWriter.onwriteend will always be called, whether the write was successful or not - FileWrite.onwrite is the correct callback to listen on successful writes - Correct misspelling in console.log for onwrite and onerror
GitToTheHub
force-pushed
the
pr-readme-correct-onwriteend
branch
from
aa6e1e9 to
beed8e8
Compare
breautek
approved these changes
Oct 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onwriteendsamples are wrong. The correct callback isonwritefor sucessful writes, as you can see here:onwrite
cordova-plugin-file/www/FileWriter.js
Lines 62 to 63 in 92caa81
onwriteend
cordova-plugin-file/www/FileWriter.js
Lines 65 to 66 in 92caa81
onwriteandonerror, where it mistakenly says "Successful file read..." instead of "write"