This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Conditionally skip the _one_ broken test for VS 2017 instead of allowing the whole suite to fail #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of allowing whole suite to fail.
janpio
approved these changes
Apr 26, 2019
|
TIL |
brody4hire
pushed a commit
that referenced
this pull request
Dec 22, 2019
...instead of allowing whole suite to fail.
brody4hire
pushed a commit
to brody4hire/cordova-windows
that referenced
this pull request
Dec 23, 2019
...instead of allowing whole suite to fail.
brody4hire
pushed a commit
to brody4hire/cordova-windows
that referenced
this pull request
Dec 25, 2019
...instead of allowing whole suite to fail.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The CI tests on AppVeyor using VS 2017 were allowed to fail completely because of one E2E test that is broken under these conditions. This is confusing and could mask any other broken tests.
Example: https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-windows/builds/23755792
Description
Instead of allowing the whole suite to fail when using VS 2017, we only skip the known-bad tests when VS 2017 on AppVeyor is used.