Fix Deprecated Symbol Literals #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace 'ab with Symbol("ab")
DAFFODIL-2152
olabusayoT
force-pushed
the
daf-2152-replace-deprecated-literals
branch
from
80e2911 to
b4b39ef
Compare
mbeckerle
approved these changes
Feb 10, 2025
| @@ -110,7 +110,7 @@ abstract class Expression extends OOLAGHostImpl() with BasicComponent { | |||
| res | |||
| } | |||
|
|
|||
| private lazy val compiledDPath_ = LV('compiledDPath) { compiledDPath } | |||
| private lazy val compiledDPath_ = LV(Symbol("compiledDPath")) { compiledDPath } | |||
There was a problem hiding this comment.
The only value of Symbol here I guess is that the strings will be interned. But we only use these strings in documentation.
My actual plan for these LV things was to use Li Haoyi's sourcecode library to obtain the symbol from the name of the lazy val itself, so that this whole argument would just disappear entirely.
However, that's beyond the call of duty for this change set.
There was a problem hiding this comment.
Should I create a ticket to track getting that done?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAFFODIL-2152