Simpify PyExpr::python_value
by using ScalarValue::into_py
#729
Labels
enhancement
New feature or request
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, we de-structure every
ScalarValue
variantdatafusion-python/src/expr.rs
Lines 308 to 319 in 860283a
But
ScalarValue
already implementsIntoPy
:https://github.com/apache/datafusion/blob/b7d2aea1dd4bb4a3abe3163dae936d7bfa5b32c9/datafusion/common/src/pyarrow.rs#L72-L76
If we want to avoid that
unwrap
, we could use theToPyArrow
trait:https://github.com/apache/datafusion/blob/b7d2aea1dd4bb4a3abe3163dae936d7bfa5b32c9/datafusion/common/src/pyarrow.rs#L55-L64
Additional context
Are there other constraints the
ScalarValue
variants thatdatafusion-python
can support other than whatdatafusion
can convert?The text was updated successfully, but these errors were encountered: