Feat/ffi scalar udf #1033
Closed
Feat/ffi scalar udf #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an table provider
… single partition, so update the unit test to check all partitions.
|
Putting into draft because we need the upstream DataFusion repository to release version 46 before this can be enabled. |
|
This could be reviewed now! |
|
Superseded by #1145 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This addresses part of #1017 - the scalar UDFs
Rationale for this change
This change enables users who have written DataFusion scalar UDFs to reuse them in
datafusion-pythonwith minimal overhead. They simply need to create a python object that exposes a PyCapsule that is theFFI_ScalarUDF.What changes are included in this PR?
Adds a function in ScalarUDF to create from a FFI object.
Add a full example and integration test.
Are there any user-facing changes?
Existing interfaces are not changed, but additional
ffi_udffunction is added.