Skip to content

Error on some GRANTs when trailing commas are enabled #1211

Closed
@MohamedAbdeen21

Description

@MohamedAbdeen21

How to reproduce

use sqlparser::{
    dialect::GenericDialect,
    parser::{Parser, ParserError, ParserOptions},
};

fn main() -> Result<(), ParserError> {
    let dialect = GenericDialect {};
    let options = ParserOptions::new().with_trailing_commas(true);

    let result = Parser::new(&dialect)
        .with_options(options)
        .try_with_sql("GRANT USAGE, SELECT ON SEQUENCE p TO u")?
        .parse_statements();

    println!("{:?}", result);

    Ok(())
}

Output

Err(ParserError("Expected ON, found: SELECT at Line: 1, Column 14"))

Expected Output

Should parse successfully.

Ok([Grant { privileges: Actions([Usage, Select { columns: None }]), objects: Sequenc
es([ObjectName([Ident { value: "p", quote_style: None }])]), grantees: [Ident { valu
e: "u", quote_style: None }], with_grant_option: false, granted_by: None }])

Cause

parse_comma_separated guesses that the comma is a trailing comma since it's followed by a reserved keyword (SELECT).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions