Support arbitrary composite access expressions #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
approved these changes
Dec 18, 2024
ayman-sigma
force-pushed
the
ayman/supportArbitraryCompositeAccess
branch
from
38edcd8 to
978f81e
Compare
ayman-sigma
force-pushed
the
ayman/supportArbitraryCompositeAccess
branch
from
978f81e to
3935b76
Compare
|
ayman-sigma
added a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Jan 3, 2025
This brings couple of fixes I put for databricks and bigquery: - apache#1598 - apache#1600
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
CompositeAccessexpression is limited to support the PostgreSQL syntax likeSELECT (on_hand.item).name FROM on_hand WHERE (on_hand.item).price > 9.This PR generalize it to support arbitrary composite access expressions.
CompositeAccessexpression is any prefix expression followed by a period then an identifier. TheCompositeAccessitself can also be nested.This change fixes issues with dialects that can access fields from another expression. For example dialects that supports
structliteral. Something likeSELECT struct(1 as a).awouldn't work before this PR.