Skip to content

Remove ListingTable and FileScanConfig Unbounded #8540

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
tustvold opened this issue Dec 14, 2023 · 3 comments · Fixed by #8573
Closed

Remove ListingTable and FileScanConfig Unbounded #8540

tustvold opened this issue Dec 14, 2023 · 3 comments · Fixed by #8573
Assignees
@tustvold
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge?

Following on from #7994 it should be possible to remove the unbounded stream support from ListingTable, as this is now provided by StreamTable.

@ozankabak @metesynnada Am I correct in thinking this?

Describe the solution you'd like

I would like to remove FileScanConfig::infinite_source and the corresponding options on CsvReadOptions, etc...

Describe alternatives you've considered

No response

Additional context

No response
@tustvold tustvold added the enhancement New feature or request label Dec 14, 2023
@ozankabak
Copy link
Contributor

ozankabak commented Dec 14, 2023 •
edited
Loading

AFAICT you are correct. I will consult with @metesynnada tomorrow to make sure about CSV options structs etc. and circle back.

@tustvold tustvold mentioned this issue Dec 14, 2023
Closed
@metesynnada
Copy link
Contributor

metesynnada commented Dec 15, 2023 •
edited
Loading

Deleting them would be logical.

@alamb
Copy link
Contributor

alamb commented Dec 17, 2023 •
edited
Loading

I think this would be a good first issue for anyone interested in helping clean up the codebase. It is well defined and there is consensus.

I think it should be straightforward

@alamb alamb added the good first issue Good for newcomers label Dec 17, 2023
@tustvold tustvold self-assigned this Dec 17, 2023
@tustvold tustvold mentioned this issue Dec 17, 2023
Closed
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 17, 2023
@tustvold
Remove ListingTable and FileScanConfig Unbounded (apache#8540)
3d52ad5
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 17, 2023
@tustvold
Remove ListingTable and FileScanConfig Unbounded (apache#8540)
611bee0
@tustvold tustvold mentioned this issue Dec 17, 2023
Merged
mustafasrepo added a commit that referenced this issue Dec 18, 2023
@tustvold @mustafasrepo
Remove ListingTable and FileScanConfig Unbounded (#8540) (#8573)
a1e959d 
* Remove ListingTable and FileScanConfig Unbounded (#8540)

* Fix substrait

* Fix logical conflicts

* Add deleted tests as ignored

---------

Co-authored-by: Mustafa Akur <mustafa.akur@synnada.ai>
@matthewgapp matthewgapp mentioned this issue Jan 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tustvold tustvold

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ListingTable and FileScanConfig Unbounded (#8540) tustvold/arrow-datafusion
4 participants
@alamb @tustvold @ozankabak @metesynnada