Refactor EliminateOuterJoin to implement OptimizerRule::rewrite()
#10081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
alamb
reviewed
Apr 15, 2024
| @@ -53,7 +53,7 @@ impl OptimizerRule for SimplifyExpressions { | |||
| _plan: &LogicalPlan, | |||
| _config: &dyn OptimizerConfig, | |||
| ) -> Result<Option<LogicalPlan>> { | |||
| internal_err!("Should have called SimplifyExpressions::try_optimize_owned") | |||
| internal_err!("Should have called SimplifyExpressions::rewrite") | |||
|
Thanks @jayzhan211, @alamb for the review! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9637.
Rationale for this change
Eliminates a
LogicalPlan::with_new_exprs()call and soExprcloning.What changes are included in this PR?
This PR:
EliminateOuterJoin::try_optimize()toEliminateOuterJoin::rewrite().eliminate_outer().SimplifyExpressions.Are these changes tested?
Yes, with existing UTs.
Are there any user-facing changes?
No.