Stop copying LogicalPlan and Exprs in DecorrelatePredicateSubquery
#10318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 30, 2024
There was a problem hiding this comment.
I think it is easier to see what is actually changed in this PR using whitespace blind diff: https://github.com/apache/datafusion/pull/10318/files?w=1
| .iter() | ||
| .any(|expr| matches!(expr, Expr::InSubquery(_) | Expr::Exists(_))); | ||
| if !has_subqueries { | ||
| return Ok(Transformed::no(LogicalPlan::Filter(filter))); |
There was a problem hiding this comment.
in the common case where there are no subqueries there will be no rewriting / cloning (which is the same as main
|
|
||
| // iterate through all exists clauses in predicate, turning each into a join | ||
| let mut cur_input = filter.input.as_ref().clone(); |
There was a problem hiding this comment.
this is one avoided clone of the input plan
| query, | ||
| where_in_expr: Some(expr), | ||
| negated: false, | ||
| } => in_subquery(expr, query.subquery.clone()), |
There was a problem hiding this comment.
these are clones of Arcs so while this PR removes them and it is less cloning realistically it doesn't matter
| @@ -37,7 +37,7 @@ use std::sync::Arc; | |||
| use arrow::datatypes::{DataType, Schema}; | |||
| use arrow::record_batch::RecordBatch; | |||
|
|
|||
| use datafusion_common::Result; | |||
| use datafusion_common::{internal_err, Result}; | |||
There was a problem hiding this comment.
This is the change from #10317 to get the CI to pass
alamb
changed the title
DecorrelatePredicateSubqueryDecorrelatePredicateSubquery
waynexia
approved these changes
May 1, 2024
|
Thanks for the review @waynexia |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9637
Closes #10289
Rationale for this change
Reduce copying in
What changes are included in this PR?
DecorrelatePredicateSubqueryAre these changes tested?
covered by existing tests
Are there any user-facing changes?
No