Single multi groupby v2 #11777
Closed
Single multi groupby v2 #11777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
core
jayzhan211
commented
Aug 2, 2024
| // benchmark time: [150.22 ms 154.31 ms 158.06 ms] | ||
| // change: [+254.76% +261.92% +270.28%] (p = 0.00 < 0.05) | ||
| // Performance has regressed. | ||
| // Found 1 outliers among 10 measurements (10.00%) |
There was a problem hiding this comment.
// this change
// Gnuplot not found, using plotters backend
// Benchmarking benchmark: Warming up for 3.0000 s
// Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 8.2s or enable flat sampling.
// benchmark time: [150.22 ms 154.31 ms 158.06 ms]
// change: [+254.76% +261.92% +270.28%] (p = 0.00 < 0.05)
// Performance has regressed.
// Found 1 outliers among 10 measurements (10.00%)
// main
// Gnuplot not found, using plotters backend
// Benchmarking benchmark: Warming up for 3.0000 s
// Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 29.0s.
// benchmark time: [2.0650 s 3.5149 s 5.1064 s]
// change: [+1182.7% +2229.6% +3244.4%] (p = 0.00 < 0.05)
// Performance has regressed.
There was a problem hiding this comment.
I got 2.1296 for main
jayzhan211
commented
Aug 2, 2024
| // change: [-6.5657% -5.6393% -4.6452%] (p = 0.00 < 0.05) | ||
| // Performance has improved. | ||
| // Found 1 outliers among 10 measurements (10.00%) | ||
| // 1 (10.00%) high mild |
There was a problem hiding this comment.
single-multi-groupby-v2
Gnuplot not found, using plotters backend
// benchmark time: [41.512 ms 41.931 ms 42.318 ms]
// change: [-6.5657% -5.6393% -4.6452%] (p = 0.00 < 0.05)
// Performance has improved.
// Found 1 outliers among 10 measurements (10.00%)
// 1 (10.00%) high mild
main
Gnuplot not found, using plotters backend
benchmark time: [43.127 ms 43.299 ms 43.636 ms]
change: [-99.150% -98.764% -97.880%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
|
I found removing pre-partition cause huge regression for many queries |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?