Skip to content

Fix bug with zero-sized buffer for StringViewArray #11841

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

XiangpengHao
Copy link
Contributor

@XiangpengHao XiangpengHao commented Aug 6, 2024

Which issue does this PR close?

Part of #11752.

Rationale for this change

The new arrow-rs implementation disallow zero-sized buffer for StringViewBuilder: apache/arrow-rs#6136

When new version of arrow-rs is released, we will trigger this bug.

  • We could also change arrow so that with_block_size takes a NonZeroU32
  • I don't think zero-sized buffer should be allowed, it creates unexpected runtime problems...

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@alamb alamb merged commit e19e982 into apache:main Aug 6, 2024
25 checks passed
@alamb
Copy link
Contributor

alamb commented Aug 6, 2024

Thank you @XiangpengHao

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants