Skip to content

[WIP] Manage group values by blocks in aggregation #11932

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 9 commits into from

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Aug 10, 2024

Which issue does this PR close?

Part of #11931

Rationale for this change

See #11931

What changes are included in this PR?

  • Define new group_idx format, but will just used in GroupValuesRows now, and not expose in interface functions.
block_id(16bit) | block offset(48bit)
  • Impl a conveter to convert the new format to old format for later compatibility (especially for GroupAccumulators).
  • Fix tests.
  • Benchmarks.

Are these changes tested?

Are there any user-facing changes?

@Rachelint Rachelint force-pushed the page-based-group-manage branch from dd5b948 to 680bf3b Compare August 10, 2024 22:59
@Rachelint Rachelint changed the title Manage group values by blocks in aggregation [WIP] Manage group values by blocks in aggregation Aug 11, 2024
@Rachelint Rachelint force-pushed the page-based-group-manage branch from 680bf3b to 6269fb7 Compare August 11, 2024 05:07
@Rachelint Rachelint force-pushed the page-based-group-manage branch from 22dd236 to c355368 Compare August 11, 2024 07:47
@Rachelint Rachelint force-pushed the page-based-group-manage branch from ee0b369 to 56399f7 Compare August 11, 2024 11:12
@Rachelint Rachelint closed this Aug 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant