Confirming UDF aliases are serialized correctly #12219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you mind fixing this or extracting this comment into a new issue? Just so it doesn't get lost. |
|
Apologies, I did it yesterday but forgot to link the issue here #12220 |
crepererum
approved these changes
Aug 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
I had created #11595 which I had created when working on #11013
When I was using
create_aggregate_expr, aliases for max_udaf wouldn't be serialized, as indicated in #11595 . However, using theAggregateExprBuildersolved the problem, so the issue was probably increate_aggregate_expr, which by the way has been removed from the codebase, so we need to update the contributors how-tohttps://github.com/apache/datafusion/blob/main/docs/source/contributor-guide/howtos.md?plain=1#L62