Make PruningPredicate's rewrite public #12835
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
commented
Oct 9, 2024
Comment on lines
1359
to
1360
| /// Notice: Does not handle [`phys_expr::InListExpr`] greater than 20, which will fall back to calling `unhandled_hook` | ||
| pub fn build_predicate_expression( |
There was a problem hiding this comment.
I'm open to new names. We could also make a wrapper that e.g. does not require required_columns and takes Option<UnhandledPredicateHook> which defaults to true.
adriangb
commented
Oct 9, 2024
Comment on lines
+483
to
+504
| pub trait UnhandledPredicateHook { | ||
| /// Called when a predicate can not be handled by DataFusion's transformation rules | ||
| /// or is referencing a column that is not in the schema. | ||
| fn handle(&self, expr: &Arc<dyn PhysicalExpr>) -> Arc<dyn PhysicalExpr>; | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| struct ConstantUnhandledPredicateHook { | ||
| default: Arc<dyn PhysicalExpr>, | ||
| } | ||
|
|
||
| impl ConstantUnhandledPredicateHook { | ||
| fn new(default: Arc<dyn PhysicalExpr>) -> Self { | ||
| Self { default } | ||
| } | ||
| } | ||
|
|
||
| impl UnhandledPredicateHook for ConstantUnhandledPredicateHook { | ||
| fn handle(&self, _expr: &Arc<dyn PhysicalExpr>) -> Arc<dyn PhysicalExpr> { | ||
| self.default.clone() | ||
| } | ||
| } |
There was a problem hiding this comment.
No strong feelings for naming these, I don't love the current names.
adriangb
force-pushed
the
rewrite-hook
branch
2 times, most recently
from
01274f9 to
a7e4b5b
Compare
adriangb
force-pushed
the
rewrite-hook
branch
from
a7e4b5b to
9c49413
Compare
|
Sorry for the churn, closing in favor of #12850 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #12606
As per #12606 (comment) the plan was to split the rewrite logic from the rest of PruningPredicate. It turns out that was as easy as making a function public, kudos to whoever wrote this originally for organizing it nicely 🥳.