Fix clippy error on wasmtest #12844
Merged
Fix clippy error on wasmtest #12844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
Oct 10, 2024
| fn datafusion_test() { | ||
| basic_exprs(); | ||
| basic_parse(); | ||
| } | ||
|
|
||
| #[wasm_bindgen_test] | ||
| #[wasm_bindgen_test(unsupported = tokio::test)] |
There was a problem hiding this comment.
According to the new feature of wasm_bindgen_test, run this test with tokio::test under non-wasm targets.
jonahgao
commented
Oct 10, 2024
| @@ -87,13 +87,14 @@ mod test { | |||
|
|
|||
| wasm_bindgen_test::wasm_bindgen_test_configure!(run_in_browser); | |||
|
|
|||
| #[wasm_bindgen_test] | |||
| #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] | |||
| #[cfg_attr(not(target_arch = "wasm32"), allow(dead_code))] | |||
There was a problem hiding this comment.
This test can't run on non-wasm targets, so add allow(dead_code).
thread 'test::datafusion_test' panicked at datafusion/wasmtest/src/lib.rs:41:1:
cannot call wasm-bindgen imported functions on non-wasm targets
alamb
approved these changes
Oct 10, 2024
|
Merging to get CI green |
This was referenced Oct 10, 2024
This was referenced Oct 16, 2024
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Oct 16, 2024
alamb
added a commit
that referenced
this pull request
Oct 16, 2024
* Update to arrow 53.1.0 on branch-42 * Allow deprecated functions * Fix clippy error on wasmtest (#12844) * Update for different file sizes --------- Co-authored-by: Jonah Gao <jonahgao@msn.com>
notfilippo
pushed a commit
to notfilippo/datafusion
that referenced
this pull request
Oct 21, 2024
alamb
pushed a commit
that referenced
this pull request
Oct 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12842.
Rationale for this change
The new release of wasm-bindgen-test causes clippy to throw errors.
PR fixed these errors and also verified locally that these tests can still run on Chrome.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No