Skip to content

Minor: Add debug log message for creating GroupValuesRows #13506

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 20, 2024

Which issue does this PR close?

related to

Rationale for this change

I want to know when the aggregation path is using the slower (but general) GroupValuesRows so we can verify that work like #13505 has been completed

What changes are included in this PR?

Add a debug log message with some comments

Are these changes tested?

N/A

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Nov 20, 2024
Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm!

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahgao jonahgao merged commit 9fb7aee into apache:main Nov 21, 2024
25 checks passed
@alamb alamb deleted the alamb/debug_type branch November 21, 2024 21:44
@alamb
Copy link
Contributor Author

alamb commented Nov 21, 2024

Thanks @jonahgao and @jonahgao

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
physical-expr Changes to the physical-expr crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants