-
Notifications
You must be signed in to change notification settings - Fork 1.5k
WIP: Add tokomak optimizer #441
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 75.28% 75.26% -0.03%
==========================================
Files 147 153 +6
Lines 24868 25542 +674
==========================================
+ Hits 18723 19223 +500
- Misses 6145 6319 +174
Continue to review full report at Codecov.
|
@Dandandan do you still plan to work on this PR? |
@Dandandan let me know if you need help with some of the todo list items, happy to help push this PR forward. |
Closing stale PRs to keep PR review list manageable. Please reopen if that is a mistake |
Which issue does this PR close?
Closes #440
TODO:
egg
dependency) an optional (off by default) feature.in
between
Rationale for this change
See #440 for a longer explanation.
I believe using a optimization library is a great way to accelerate developing & increase the number of optimizations possible.
Also, the more optimizations we add, the more we end up building a own (probably worse) version of a optimization framework.
What changes are included in this PR?
Adds a new optimizer
Tokomak
that does expression simplification based on rewrite rules.Are there any user-facing changes?