Minor: Comments to .asf.yaml #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
+1
Could you trigger the docs job with .asf.yaml change?
diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml
index fdbcf6ab..998c6203 100644
--- a/.github/workflows/docs.yaml
+++ b/.github/workflows/docs.yaml
@@ -3,6 +3,7 @@ on:
branches:
- main
paths:
+ - .asf.yaml
- .github/workflows/docs.yaml
- docs/**
.asf.yaml need to copy to the asf-site branch.
andygrove
approved these changes
Mar 24, 2023
Will do as a follow on PR edit: #5726 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5500
Rationale for this change
Now that we have the automated publishing working, I want to document how the process works. #5687 was aprt.
cc @martin-g @kou
What changes are included in this PR?
Add some comments to
.asf.yamlso my future self remembers what the parts are forAre these changes tested?
N/a
Are there any user-facing changes?