Skip to content

Support Decimal256 in Min/Max aggregate expressions #7881

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 20, 2023

Which issue does this PR close?

Closes #7880.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Oct 20, 2023
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @viirya 👍

@Dandandan Dandandan merged commit 113a7bd into apache:main Oct 20, 2023
@Dandandan
Copy link
Contributor

Nice, thanks @viirya

@viirya
Copy link
Member Author

viirya commented Oct 20, 2023

Thank you @Weijun-H @Dandandan

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Decimal256 in Min/Max aggregate expressions
4 participants