Skip to content

Fix bug in optimizing a nested count #8459

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 7, 2023
Merged

Fix bug in optimizing a nested count #8459

merged 8 commits into from
Dec 7, 2023

Conversation

Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #8450

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Dec 7, 2023
@Dandandan Dandandan changed the title Fix nested count Fix bug in optimizing a nested count Dec 7, 2023
viirya
viirya approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add one test to sqllogictest too?

@Dandandan @viirya
Update datafusion/optimizer/src/optimize_projections.rs
bb74288 
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@Dandandan
Copy link
Contributor Author

Maybe also add one test to sqllogictest too?

Good one, will add

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 7, 2023
@Dandandan Dandandan merged commit d5dd535 into apache:main Dec 7, 2023
@Dandandan Dandandan mentioned this pull request Dec 8, 2023
Closed
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
@Dandandan @viirya @appletreeisyellow
Fix bug in optimizing a nested count (apache#8459)
5f69fc7 
* Fix nested count optimization

* fmt

* extend comment

* Clippy

* Update datafusion/optimizer/src/optimize_projections.rs

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>

* Add sqllogictests

* Fmt

---------

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested count fails
2 participants
@Dandandan @viirya