Skip to content

Minor: update pbjson_dependency #8470

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

Minor: update pbjson_dependency #8470

merged 1 commit into from
Dec 13, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 8, 2023

Let's keep dependencies up to date

Especially since other parts of the system use pbjson 0.6.0 already: https://github.com/apache/arrow-datafusion/blob/34b0445b778c503f4e65b384ee9ec119ec90044a/datafusion/proto/gen/Cargo.toml#L34

I am not sure why this one did not

@alamb alamb marked this pull request as ready for review December 8, 2023 20:24
metesynnada
metesynnada approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alamb alamb merged commit 0678a69 into apache:main Dec 13, 2023
@alamb
Copy link
Contributor Author

alamb commented Dec 13, 2023

Thank you for the review @metesynnada

@alamb alamb deleted the alamb/update_pbjson branch December 13, 2023 18:55
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@metesynnada metesynnada metesynnada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @metesynnada