Skip to content

Optimize the parameter types of ParamValues's methods #8613

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

kawadakk
Copy link
Contributor

Which issue does this PR close?

Closes #8612.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Dec 21, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @kawadakk

@alamb
Copy link
Contributor

alamb commented Dec 22, 2023

I took the liberty of merging up from main on this branch to make sure there are no logical conflicts

@alamb alamb merged commit e467492 into apache:main Dec 22, 2023
@kawadakk kawadakk deleted the patch/param-values-borrowed-params branch February 1, 2024 04:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the parameter types of ParamValues's methods to avoid expensive conversion
2 participants