Skip to content

Add schema_err! error macros with optional backtrace #8620

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Jan 6, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes partially #7360.

Rationale for this change

Continue covering Datafusion Errors with error macros supporting optional backtrace

What changes are included in this PR?

introduced schema_err! and schema_datafusion_err! macros with optional backtrace, to represent Err(DatafusionError::SchemaError) and DatafusionError::SchemaError(_)

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Dec 21, 2023
@comphead comphead marked this pull request as draft December 22, 2023 18:15
@comphead comphead marked this pull request as ready for review December 22, 2023 18:15
@@ -99,6 +99,11 @@ jobs:
rust-version: stable
- name: Run tests (excluding doctests)
run: cargo test --lib --tests --bins --features avro,json,backtrace
env:
Copy link
Contributor Author

@comphead comphead Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding more stack as q54 keeps failing.

thread 'tpcds_physical_q54' has overflowed its stack

This PR shouldn't impact stack as the introduced SchemaError second param is boxed and thus resides in heap, in stack there is only a pointer. However it is what is is, I'm happy to get the opinion from other contributors on this

@comphead comphead mentioned this pull request Dec 23, 2023
23 tasks
@comphead
Copy link
Contributor Author

@alamb would you mind reviewing?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me -- thank you @comphead

@comphead
Copy link
Contributor Author

comphead commented Jan 4, 2024

Here the problem is backtrace-rs regression in Rust lang
rust-lang/rust#119560

@alamb
Copy link
Contributor

alamb commented Jan 4, 2024

Here the problem is backtrace-rs regression in Rust lang rust-lang/rust#119560

Wow -- super sleuth 🕵️

@comphead
Copy link
Contributor Author

comphead commented Jan 5, 2024

Here the problem is backtrace-rs regression in Rust lang rust-lang/rust#119560

Wow -- super sleuth 🕵️

Tbh, all kudos to @Jefffrey who ran tons of experiments to narrow down the problem when we were investigating windows CI slowness, and eventually he came to backtrace root cause.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants