Fix #8507: Non-null sub-field on nullable struct-field has wrong nullity #8623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
alamb
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thank you for this contribution @marvinlanhenke -- it makes sense to me
datafusion/expr/src/expr_schema.rs
Outdated
| let schema = DFSchema::new_with_metadata(vec![fields], HashMap::new()).unwrap(); | ||
|
|
||
| let expr = col("parent").field("child"); | ||
| assert_eq!(expr.nullable(&schema).unwrap(), true); |
|
@marvinlanhenke it looks like there is a clippy error preventing a clean CI run: https://github.com/apache/arrow-datafusion/actions/runs/7299570999/job/19905117841?pr=8623 Is there any chance you can fix that so we can merge this PR? |
|
@alamb thanks for the approval - i just committed the |
|
THanks again @marvinlanhenke |
marvinlanhenke
deleted the
fix_wrong_nullity_on_nullable_struct_field
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8507.
Rationale for this change
If parent struct is nullable; sub-fields should also be.
What changes are included in this PR?
As suggested in #8507:
I added a test to reproduce the bug with the schema described.
Then I introduced a simple guard clause to check if the parent col is nullable; if it is return early.
Are these changes tested?
Change is tested by
test_nested_schema_nullability.Are there any user-facing changes?
No.