Skip to content

Minor: Avoid memory copy in construct window exprs #8718

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

Minor: Avoid memory copy in construct window exprs #8718

merged 1 commit into from
Jan 3, 2024

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Jan 2, 2024
@Ted-Jiang Ted-Jiang requested a review from alamb January 2, 2024 08:08
@Ted-Jiang Ted-Jiang changed the title [Minor] Avoid memory copy in construct window exprs Minor: Avoid memory copy in construct window exprs Jan 2, 2024
alamb
alamb approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @Ted-Jiang

cc @mustafasrepo

@alamb alamb mentioned this pull request Jan 2, 2024
Closed
9 tasks
@alamb alamb merged commit 881d03f into apache:main Jan 3, 2024
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ted-Jiang @alamb