Minor: remove null in array-append and array-prepend
#8901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
comphead
reviewed
Jan 18, 2024
| @@ -1577,9 +1577,9 @@ select | |||
| query ???? | |||
| select | |||
| array_append(arrow_cast(make_array(), 'LargeList(Null)'), 4), | |||
| array_append(make_array(), null), | |||
There was a problem hiding this comment.
tests without arrow-case looks valid for me, should we delete them?
There was a problem hiding this comment.
right, arrow-cast, no worries, I found we already have such cases in array.slt
alamb
reviewed
Jan 19, 2024
| @@ -1031,12 +1031,6 @@ where | |||
| let res = match list_array.value_type() { | |||
| DataType::List(_) => concat_internal::<i32>(args)?, | |||
| DataType::LargeList(_) => concat_internal::<i64>(args)?, | |||
| DataType::Null => { | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #8625 #8317 Thanks @jayzhan211 effort, we can remove
NULLinarray-appendandarray-prependRationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?