Optimize MIN/MAX when relation is empty #8940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
viirya
commented
Jan 21, 2024
Comment on lines
+3279
to
+3287
| query TT | ||
| EXPLAIN SELECT MIN(col0) FROM empty; | ||
| ---- | ||
| logical_plan | ||
| Aggregate: groupBy=[[]], aggr=[[MIN(empty.col0)]] | ||
| --TableScan: empty projection=[col0] | ||
| physical_plan | ||
| ProjectionExec: expr=[NULL as MIN(empty.col0)] | ||
| --PlaceholderRowExec |
There was a problem hiding this comment.
Before this patch, the query plan looks like:
logical_plan
Aggregate: groupBy=[[]], aggr=[[MIN(empty.col0)]]
--TableScan: empty projection=[col0]
physical_plan
AggregateExec: mode=Single, gby=[], aggr=[MIN(empty.col0)]
--MemoryExec: partitions=1, partition_sizes=[0]
9 tasks
|
Thank you @alamb |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We can optimize MIN/MAX in the cases of input relation is empty.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?