[MINOR]: Fix Optimize Projections Bug #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
alamb
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Looks good to me -- thank you for the quick fix @mustafasrepo
cc @lewiszlw
9 tasks
|
I tested and this works as expected. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8978.
Rationale for this change
Aggregate requires at least one grouping or aggregate expression. In these cases, we do not optimize away all of the aggregate expressions, we keep one aggregate expression. However, because of the place of empty check, we didnot propagate its requirement below. This PR moves this check above so that its requirements can be propagated below.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?