Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feat](Nereids) support alter system drop all broker command #48208

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

xiedeyantu
Copy link
Contributor

What problem does this PR solve?

Related PR: #42784

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xiedeyantu
Copy link
Contributor Author

run buildall

@xiedeyantu
Copy link
Contributor Author

@starocean999 @LiBinfeng-01 please review, thanks.

@doris-robot
Copy link

TPC-H: Total hot run time: 31359 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3505685ff290a7a8728299eeaf8ddff54dd1dae3, data reload: false

------ Round 1 ----------------------------------
q1	17585	5384	5075	5075
q2	2055	294	173	173
q3	10411	1219	742	742
q4	10203	1002	538	538
q5	7520	2377	2316	2316
q6	187	165	134	134
q7	902	748	597	597
q8	9317	1301	1168	1168
q9	4743	4506	4578	4506
q10	6814	2303	1875	1875
q11	462	268	249	249
q12	358	354	215	215
q13	17785	3642	3094	3094
q14	228	220	211	211
q15	519	474	450	450
q16	629	604	583	583
q17	585	851	339	339
q18	6632	6228	6152	6152
q19	1207	938	535	535
q20	299	316	191	191
q21	2730	2106	1923	1923
q22	364	333	293	293
Total cold run time: 101535 ms
Total hot run time: 31359 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5197	5118	5144	5118
q2	231	336	227	227
q3	2139	2678	2352	2352
q4	1438	1817	1371	1371
q5	4249	4124	4151	4124
q6	209	169	126	126
q7	1870	1814	1657	1657
q8	2560	2608	2580	2580
q9	7422	7308	7337	7308
q10	3090	3257	2827	2827
q11	579	537	502	502
q12	703	811	648	648
q13	3420	3906	3341	3341
q14	300	304	266	266
q15	513	485	465	465
q16	647	693	631	631
q17	1120	1570	1346	1346
q18	7549	7444	7322	7322
q19	796	778	882	778
q20	1954	2015	1907	1907
q21	5439	5042	4740	4740
q22	621	574	548	548
Total cold run time: 52046 ms
Total hot run time: 50184 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190412 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3505685ff290a7a8728299eeaf8ddff54dd1dae3, data reload: false

query1	1377	925	945	925
query2	6230	1896	1889	1889
query3	11087	4596	4579	4579
query4	25384	23830	23366	23366
query5	4295	661	502	502
query6	284	207	187	187
query7	3999	524	302	302
query8	314	247	242	242
query9	8492	2555	2569	2555
query10	449	312	239	239
query11	15311	15103	14813	14813
query12	146	111	103	103
query13	1547	534	387	387
query14	9436	6343	6583	6343
query15	214	204	174	174
query16	7271	577	475	475
query17	1191	746	630	630
query18	1723	399	323	323
query19	218	193	161	161
query20	125	125	119	119
query21	213	136	110	110
query22	4743	4794	4309	4309
query23	34324	33610	33366	33366
query24	7947	2471	2432	2432
query25	506	473	408	408
query26	1212	298	156	156
query27	2794	488	339	339
query28	4378	2467	2414	2414
query29	666	559	422	422
query30	219	189	150	150
query31	921	863	867	863
query32	73	67	63	63
query33	544	362	304	304
query34	789	878	538	538
query35	836	839	764	764
query36	983	981	899	899
query37	118	100	72	72
query38	4401	4446	4141	4141
query39	1499	1445	1420	1420
query40	214	111	99	99
query41	54	52	52	52
query42	124	117	105	105
query43	516	510	475	475
query44	1330	816	807	807
query45	183	180	169	169
query46	881	1048	654	654
query47	1887	1892	1834	1834
query48	410	427	315	315
query49	780	507	445	445
query50	696	755	427	427
query51	4279	4330	4229	4229
query52	112	107	100	100
query53	229	260	190	190
query54	494	478	409	409
query55	85	82	83	82
query56	276	273	249	249
query57	1181	1202	1136	1136
query58	258	243	242	242
query59	2824	2886	2751	2751
query60	317	294	265	265
query61	119	117	114	114
query62	806	734	673	673
query63	232	195	193	193
query64	4911	1132	680	680
query65	3312	3234	3252	3234
query66	1077	398	313	313
query67	16153	15539	15503	15503
query68	7772	772	506	506
query69	437	286	263	263
query70	1191	1042	1119	1042
query71	382	310	262	262
query72	5694	3647	3709	3647
query73	642	740	348	348
query74	9193	9335	9008	9008
query75	3122	3174	2697	2697
query76	2740	1156	753	753
query77	487	379	299	299
query78	10018	10004	9330	9330
query79	2776	825	599	599
query80	589	522	449	449
query81	503	270	239	239
query82	712	127	99	99
query83	183	181	154	154
query84	239	94	74	74
query85	780	344	364	344
query86	367	296	277	277
query87	4433	4691	4366	4366
query88	4236	2218	2180	2180
query89	406	336	284	284
query90	1911	190	189	189
query91	139	143	105	105
query92	75	61	56	56
query93	1984	983	570	570
query94	705	465	282	282
query95	344	266	264	264
query96	498	544	282	282
query97	2816	2870	2759	2759
query98	228	199	198	198
query99	1327	1429	1258	1258
Total cold run time: 276928 ms
Total hot run time: 190412 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.86 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3505685ff290a7a8728299eeaf8ddff54dd1dae3, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.61	0.10	0.10
query5	0.41	0.41	0.39
query6	1.15	0.67	0.66
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.53
query10	0.58	0.58	0.57
query11	0.16	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.70	2.71	2.67
query15	0.91	0.84	0.85
query16	0.38	0.39	0.38
query17	1.00	1.00	1.00
query18	0.22	0.19	0.19
query19	1.89	1.83	2.00
query20	0.01	0.01	0.01
query21	15.34	0.88	0.55
query22	0.75	1.20	0.71
query23	14.89	1.35	0.62
query24	6.86	2.09	1.11
query25	0.52	0.24	0.10
query26	0.57	0.15	0.14
query27	0.05	0.05	0.05
query28	9.88	0.85	0.42
query29	12.53	3.90	3.27
query30	0.24	0.08	0.06
query31	2.83	0.58	0.37
query32	3.23	0.54	0.48
query33	2.96	2.96	2.99
query34	15.71	5.17	4.53
query35	4.59	4.58	4.59
query36	0.65	0.49	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.88 s
Total hot run time: 30.86 s

@xiedeyantu
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31186 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78f23b5f154bf21bc246d9d527e195aca197de62, data reload: false

------ Round 1 ----------------------------------
q1	17613	5289	5114	5114
q2	2044	290	162	162
q3	10435	1253	736	736
q4	10218	1027	534	534
q5	7691	2477	2256	2256
q6	181	169	128	128
q7	893	735	603	603
q8	9297	1366	1130	1130
q9	4858	4571	4542	4542
q10	6873	2311	1870	1870
q11	482	286	266	266
q12	355	359	215	215
q13	17778	3630	3091	3091
q14	227	225	204	204
q15	508	470	453	453
q16	625	605	583	583
q17	580	861	334	334
q18	6574	6086	6186	6086
q19	1781	966	535	535
q20	305	312	180	180
q21	2755	2091	1874	1874
q22	353	326	290	290
Total cold run time: 102426 ms
Total hot run time: 31186 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5158	5118	5086	5086
q2	240	329	232	232
q3	2160	2641	2269	2269
q4	1437	1792	1366	1366
q5	4202	4080	4138	4080
q6	204	163	122	122
q7	1854	1824	1652	1652
q8	2592	2646	2512	2512
q9	7164	7143	7133	7133
q10	3030	3213	2793	2793
q11	569	527	510	510
q12	685	746	638	638
q13	3440	3839	3320	3320
q14	283	318	272	272
q15	505	450	469	450
q16	635	683	631	631
q17	1095	1563	1338	1338
q18	7703	7352	7371	7352
q19	779	923	972	923
q20	1948	1997	1890	1890
q21	5297	4997	4778	4778
q22	580	554	516	516
Total cold run time: 51560 ms
Total hot run time: 49863 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189697 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78f23b5f154bf21bc246d9d527e195aca197de62, data reload: false

query1	1296	937	919	919
query2	6154	1905	1902	1902
query3	11006	4368	4292	4292
query4	56025	25626	23304	23304
query5	5137	556	504	504
query6	364	187	184	184
query7	5136	493	293	293
query8	322	248	245	245
query9	6336	2574	2553	2553
query10	426	299	248	248
query11	15105	14991	14792	14792
query12	166	114	109	109
query13	1173	499	398	398
query14	11022	6649	6396	6396
query15	212	214	173	173
query16	7094	658	492	492
query17	1070	735	566	566
query18	1550	435	322	322
query19	198	212	173	173
query20	134	144	130	130
query21	210	129	102	102
query22	4377	4414	4595	4414
query23	33907	33528	33300	33300
query24	5751	2431	2380	2380
query25	449	450	396	396
query26	684	286	161	161
query27	1721	522	332	332
query28	2881	2489	2425	2425
query29	539	567	421	421
query30	220	190	161	161
query31	892	849	781	781
query32	69	64	60	60
query33	452	356	291	291
query34	739	883	489	489
query35	810	890	752	752
query36	938	1010	881	881
query37	116	96	77	77
query38	4369	4347	4265	4265
query39	1511	1420	1492	1420
query40	211	117	106	106
query41	50	53	57	53
query42	121	110	102	102
query43	523	532	474	474
query44	1274	776	775	775
query45	180	181	173	173
query46	884	1065	653	653
query47	1852	1869	1816	1816
query48	397	428	319	319
query49	716	527	442	442
query50	711	737	417	417
query51	4246	4248	4187	4187
query52	115	110	94	94
query53	226	257	189	189
query54	473	487	420	420
query55	84	79	78	78
query56	284	268	263	263
query57	1185	1218	1130	1130
query58	240	250	237	237
query59	2789	2935	2843	2843
query60	308	278	264	264
query61	119	120	116	116
query62	750	721	668	668
query63	230	190	191	190
query64	1429	1061	666	666
query65	3172	3135	3121	3121
query66	709	383	297	297
query67	15875	15706	15395	15395
query68	5349	771	505	505
query69	515	289	261	261
query70	1197	1132	1109	1109
query71	425	284	271	271
query72	6287	3580	3716	3580
query73	1066	728	344	344
query74	9184	9183	9053	9053
query75	3320	3150	2689	2689
query76	3796	1165	715	715
query77	537	372	285	285
query78	10005	10060	9275	9275
query79	2395	822	607	607
query80	603	529	501	501
query81	500	275	231	231
query82	641	124	95	95
query83	181	172	150	150
query84	291	99	73	73
query85	784	349	302	302
query86	391	284	275	275
query87	4502	4376	4363	4363
query88	3775	2215	2176	2176
query89	419	315	286	286
query90	1859	262	188	188
query91	138	138	109	109
query92	78	60	53	53
query93	1943	999	562	562
query94	663	397	295	295
query95	345	258	254	254
query96	504	544	281	281
query97	2822	2825	2732	2732
query98	219	205	195	195
query99	1311	1395	1291	1291
Total cold run time: 295759 ms
Total hot run time: 189697 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78f23b5f154bf21bc246d9d527e195aca197de62, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.43	0.45	0.41
query6	1.17	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.52	0.52
query10	0.57	0.56	0.57
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.63	0.60	0.59
query14	2.71	2.74	2.71
query15	0.91	0.83	0.84
query16	0.37	0.36	0.39
query17	1.02	1.00	0.99
query18	0.21	0.19	0.18
query19	1.91	1.84	1.99
query20	0.01	0.02	0.02
query21	15.35	0.91	0.54
query22	0.75	1.15	0.77
query23	14.81	1.33	0.62
query24	7.84	0.76	1.02
query25	0.49	0.32	0.11
query26	0.44	0.16	0.13
query27	0.05	0.05	0.04
query28	9.95	0.84	0.42
query29	12.52	3.95	3.31
query30	0.25	0.08	0.06
query31	2.83	0.59	0.37
query32	3.22	0.54	0.46
query33	2.99	3.00	3.02
query34	15.72	5.12	4.46
query35	4.55	4.53	4.51
query36	0.66	0.49	0.47
query37	0.10	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.04
Total cold run time: 105.77 s
Total hot run time: 30.5 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 24, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit c6643c6 into apache:master Feb 24, 2025
25 of 26 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants