Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

java.sql.Time & java.sql.Date #219

Merged
merged 9 commits into from
Aug 30, 2020
Merged

Conversation

zhangshen023
Copy link
Contributor

What this PR does:
java class java.sql.Time & java.sql.Date refer to hessian.Time & hessian.Date
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
can use hessian.Time & hessian.Date in go for communicating with java.sql.Time & java.sql.Date in java


@AlexStocks AlexStocks requested review from gaoxinge and wongoo and removed request for gaoxinge August 16, 2020 06:42
@AlexStocks
Copy link
Contributor

@zhangshen023 pls fix the travis failure.

@AlexStocks AlexStocks closed this Aug 16, 2020
@AlexStocks AlexStocks reopened this Aug 16, 2020
@zhangshen023
Copy link
Contributor Author

ok,i will make a try

@wongoo
Copy link
Contributor

wongoo commented Aug 17, 2020

NOT AGREE to add the Date&Time definition in hessian package, and there already java8_time package in which it contains date and time definition. If it's really necessary , suggestion to move to a new package java_sql_time.

@zhangshen023
Copy link
Contributor Author

NOT AGREE to add the Date&Time definition in hessian package, and there already java8_time package in which it contains date and time definition. If it's really necessary , suggestion to move to a new package java_sql_time.

good suggestion.

@AlexStocks AlexStocks merged commit d3e7ea2 into apache:master Aug 30, 2020
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
java.sql.Time & java.sql.Date
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants