add metrics #573
Merged
add metrics #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## develop #573 +/- ##
===========================================
- Coverage 54.68% 54.67% -0.02%
===========================================
Files 671 671
Lines 78611 78664 +53
===========================================
+ Hits 42992 43008 +16
- Misses 31965 31983 +18
- Partials 3654 3673 +19
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
baerwang
reviewed
Sep 6, 2023
AlexStocks
approved these changes
Sep 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
有待梦超再 review |
mark4z
approved these changes
Sep 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: There are 2 metrics filter: "dgp.filter.http.metric" and "dgp.filter.http.prometheusmetric". Them do similar things. But dgp.filter.http.prometheusmetric support push mode only that is not recommend. This issue move some metric of prometheusmetric to "dgp.filter.http.metric" .
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: