Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add task pool for getty #141

Merged
merged 4 commits into from
Jul 28, 2019
Merged

add task pool for getty #141

merged 4 commits into from
Jul 28, 2019

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

add task pool for getty

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #141 into develop will decrease coverage by 1.39%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #141     +/-   ##
==========================================
- Coverage    68.93%   67.53%   -1.4%     
==========================================
  Files           69       69             
  Lines         4371     4383     +12     
==========================================
- Hits          3013     2960     -53     
- Misses        1063     1128     +65     
  Partials       295      295
Impacted Files Coverage Δ
protocol/dubbo/config.go 41.66% <ø> (ø) ⬆️
protocol/dubbo/pool.go 59.23% <100%> (-15.77%) ⬇️
protocol/dubbo/client.go 68.38% <33.33%> (-1.62%) ⬇️
protocol/dubbo/server.go 66.25% <42.85%> (-2.67%) ⬇️
protocol/dubbo/listener.go 53.95% <0%> (-10.7%) ⬇️
protocol/dubbo/codec.go 73.52% <0%> (-8.83%) ⬇️
protocol/dubbo/readwriter.go 71.79% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2e60...8dd9f77. Read the comment docs.

config/testdata/consumer_config.yml Outdated Show resolved Hide resolved
config/testdata/provider_config.yml Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 688a156 into apache:develop Jul 28, 2019
LaurenceLiZhixin added a commit to LaurenceLiZhixin/dubbo-go that referenced this pull request Jul 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants