Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support nacos registry #151

Merged
merged 6 commits into from
Aug 12, 2019
Merged

support nacos registry #151

merged 6 commits into from
Aug 12, 2019

Conversation

lzp0412
Copy link
Contributor

@lzp0412 lzp0412 commented Aug 3, 2019

Special notes for your reviewer:
registry pkg unit test is done,see ./registry/nacos/registry_test.go;
java-client invoke go-server test is done;
go-client invoke java-server test is done;
go-client invoke go-server test is done
Does this PR introduce a user-facing change?:
NONE

@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #151 into develop will increase coverage by 0.13%.
The diff coverage is 76.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #151      +/-   ##
==========================================
+ Coverage    69.26%   69.4%   +0.13%     
==========================================
  Files           81      83       +2     
  Lines         4656    4870     +214     
==========================================
+ Hits          3225    3380     +155     
- Misses        1116    1156      +40     
- Partials       315     334      +19
Impacted Files Coverage Δ
config/registry_config.go 90% <0%> (-3.75%) ⬇️
config/reference_config.go 82.75% <100%> (+0.2%) ⬆️
config/service_config.go 65.82% <100%> (+0.43%) ⬆️
registry/nacos/registry.go 74% <74%> (ø)
registry/nacos/listener.go 80% <80%> (ø)
cluster/cluster_impl/base_cluster_invoker.go 54.71% <0%> (-16.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046699a...d448aa8. Read the comment docs.

registry/nacos/listener.go Outdated Show resolved Hide resolved
registry/nacos/listener.go Outdated Show resolved Hide resolved
registry/nacos/listener.go Outdated Show resolved Hide resolved
registry/nacos/listener.go Outdated Show resolved Hide resolved
registry/nacos/listener.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

LGTM

@hxmhlt hxmhlt merged commit 96bf3ea into apache:develop Aug 12, 2019
LaurenceLiZhixin pushed a commit to LaurenceLiZhixin/dubbo-go that referenced this pull request Jul 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants