Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #163] clean heartbeat from PendingResponse #166

Merged
merged 2 commits into from
Aug 14, 2019
Merged

[ISSUE #163] clean heartbeat from PendingResponse #166

merged 2 commits into from
Aug 14, 2019

Conversation

sxllwx
Copy link
Member

@sxllwx sxllwx commented Aug 14, 2019

What this PR does:

clean heartbea-pkg response from protocol.dubbo.Client.pendingResponses .

Which issue(s) this PR fixes:

Fixes #163

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #166 into develop will decrease coverage by 0.9%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
- Coverage    67.51%   66.61%   -0.91%     
===========================================
  Files           88       88              
  Lines         5474     5475       +1     
===========================================
- Hits          3696     3647      -49     
- Misses        1393     1445      +52     
+ Partials       385      383       -2
Impacted Files Coverage Δ
protocol/dubbo/listener.go 54.16% <100%> (-10.49%) ⬇️
protocol/dubbo/pool.go 59.23% <0%> (-15.77%) ⬇️
protocol/dubbo/codec.go 73.52% <0%> (-8.83%) ⬇️
protocol/dubbo/readwriter.go 71.79% <0%> (-2.57%) ⬇️
registry/etcdv3/registry.go 55.74% <0%> (-1.15%) ⬇️
cluster/cluster_impl/base_cluster_invoker.go 71.69% <0%> (+16.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcb593...a3a566b. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 4abb36f into apache:develop Aug 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants