Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix:zk high memory bug #168

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Fix:zk high memory bug #168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d353d2
Fix:zk_hignmem_bug
hxmhlt Aug 19, 2019
18a9a4c
Mod:comment
hxmhlt Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions remoting/zookeeper/listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,20 @@ func (l *ZkEventListener) listenDirEvent(zkPath string, listener remoting.DataLi

// listen l service node
dubboPath := path.Join(zkPath, c)

//Add to save into the path map to avoid duplicate listen
hxmhlt marked this conversation as resolved.
Show resolved Hide resolved
l.pathMapLock.Lock()
_, ok := l.pathMap[dubboPath]
l.pathMapLock.Unlock()
if ok {
logger.Warnf("@zkPath %s has already been listened.", zkPath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a log prefix: "[listener]ZkEventListener]"

continue
}

l.pathMapLock.Lock()
l.pathMap[dubboPath] = struct{}{}
l.pathMapLock.Unlock()

content, _, err := l.client.Conn.Get(dubboPath)
if err != nil {
logger.Errorf("Get new node path {%v} 's content error,message is {%v}", dubboPath, perrors.WithStack(err))
Expand Down