Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Imp: remove client from pool before closing it #190

Merged
merged 2 commits into from
Sep 7, 2019

Conversation

AlexStocks
Copy link
Contributor

What this PR does:

remove client from pool before closing it to ensure other task can not got it.

@codecov-io
Copy link

Codecov Report

Merging #190 into develop will increase coverage by 1.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage     66.8%   67.82%   +1.01%     
===========================================
  Files           94       94              
  Lines         5862     5864       +2     
===========================================
+ Hits          3916     3977      +61     
+ Misses        1535     1474      -61     
- Partials       411      413       +2
Impacted Files Coverage Δ
protocol/dubbo/pool.go 73.6% <60%> (+16.16%) ⬆️
protocol/dubbo/readwriter.go 74.35% <0%> (+2.56%) ⬆️
protocol/dubbo/codec.go 82.35% <0%> (+8.82%) ⬆️
protocol/dubbo/listener.go 64.81% <0%> (+10.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2ddb6...a588636. Read the comment docs.

@AlexStocks
Copy link
Contributor Author

If there is no problems, pls merge it. @hxmhlt @fangyincheng

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hxmhlt hxmhlt merged commit bb1216a into apache:develop Sep 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants