Mod:cancel listener dir when zkpath end of providers/ & consumers/ #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxmhlt
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #359 +/- ##
===========================================
- Coverage 66.74% 66.57% -0.17%
===========================================
Files 150 150
Lines 7936 7938 +2
===========================================
- Hits 5297 5285 -12
- Misses 2137 2149 +12
- Partials 502 504 +2
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Feb 16, 2020
config/config_loader.go
Outdated
| @@ -195,20 +195,20 @@ func GetApplicationConfig() *ApplicationConfig { | |||
|
|
|||
| // GetProviderConfig find the provider config | |||
| // if not found, create new one | |||
| func GetProviderConfig() ProviderConfig { | |||
| func GetProviderConfig() *ProviderConfig { | |||
There was a problem hiding this comment.
are u sure u need to change the value of the ProviderConfig by its pointer?
There was a problem hiding this comment.
Be same as other func. GetMetricConfig / GetApplicationConfig
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: