Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DUBBO-3802]: roll back change made by 3520 #3935

Merged
merged 1 commit into from
Apr 26, 2019
Merged

[DUBBO-3802]: roll back change made by 3520 #3935

merged 1 commit into from
Apr 26, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Apr 26, 2019

What is the purpose of the change

Revert "Merge pull request #3520, fix #538 polish the process of deciding the ip to bind."

This reverts commit ade0cd7 (#3520)

Revert this change to address issue #3802

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

…ding the ip to bind."

This reverts commit ade0cd7
@codecov-io
Copy link

Codecov Report

Merging #3935 into master will decrease coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3935      +/-   ##
============================================
- Coverage     63.66%   63.63%   -0.03%     
  Complexity       71       71              
============================================
  Files           713      713              
  Lines         31455    31529      +74     
  Branches       5070     5082      +12     
============================================
+ Hits          20025    20065      +40     
- Misses         9134     9172      +38     
+ Partials       2296     2292       -4
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/config/AbstractInterfaceConfig.java 72% <0%> (-0.42%) 0 <0> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.07% <0%> (-0.08%) 0 <0> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.08% <50%> (+1.49%) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.97% <50%> (-0.82%) 0 <0> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 65.15% <0%> (-4.53%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0%> (-2.18%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.84% <0%> (+0.38%) 0% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083605a...41d7e0e. Read the comment docs.

Copy link
Contributor

@lexburner lexburner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexburner lexburner merged commit b8d9f76 into apache:master Apr 26, 2019
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
…cess of deciding the ip to bind." (apache#3935)

This reverts commit ade0cd7
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obtain local address incorrectly sometimes in dubbo
3 participants