Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(label): fix endLabel fails with null data #18841

Merged
merged 3 commits into from
Jul 5, 2023
+47 −2
Merged

fix(label): fix endLabel fails with null data #18841

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f9e2d3
fix(endLabel): endLabel fail with null data #18839
Ovilia Jul 4, 2023
91d1e03
test(endLabel): add test case
Ovilia Jul 4, 2023
1d10ba8
fix(endLabel): remove check of inner
Ovilia Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/chart/line/LineView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,10 @@ class LineView extends ChartView {
});
}
if (valueAnimation) {
labelInner(endLabel).setLabelText(value);
const inner = labelInner(endLabel);
if (inner && typeof inner.setLabelText === 'function') {
inner.setLabelText(value);
}
}
}
}
Expand Down
44 changes: 43 additions & 1 deletion test/line-endLabel.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.