Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

De 5143 #31

Closed
wants to merge 2 commits into from
Closed

De 5143 #31

wants to merge 2 commits into from

Conversation

kurnoolsaketh
Copy link

Description

This PR is for review purposes only – once it's approved, I will close it and push this branch version to our codeartifact.

Currently, the upstream opensearch connector fails at runtime while parsing OS 2.x server responses. This is happening because the Osearch high level rest client is out of sync with OS 2.x (specifically, the client expects a type field that is no longer included in the response body). This has been removed from the rest client in version 2.3.

There's an open PR for the issue upstream with the exact same change: #4. Until this is sorted, this will have to do.

Validation

  • send records to OS on AWS
    • 2.7
    • 2.6
    • ...
  • send data to self hosted OS

Security Considerations

Are there any security or data concerns to consider? If so, please describe them below.
This may include, but is not limited to:

  • Potential SQL injection
  • Handling customer credentials
  • Sensitive information in log messages
  • Dependencies with known vulnerabilities
  • Other issues listed in the OWASP Top 10
  • Yes
  • No

Type of change

  • Task - An internal-only task that has no visible customer effect.
  • New feature - New functionality that is user-visible.
  • Improvement - Existing functionality works better than it did before.
  • Bug fix - Something didn’t work as expected, but now it does.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Others (please describe)

Documentation

  • This pull request introduce a new feature

If yes, how is the feature documented?

  • Not applicable
  • Docs - Please provide links to docs
  • Javadocs
  • Not documented

Checklists

  • Pull request has a descriptive title linked with JIRA ticket in the format DE-XXXX: Summary
    where DE is the JIRA project short code, XXXX is the number, and Summary is the JIRA summary.
  • Pull request has reviewers assigned.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 31, 2023

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant