GUACAMOLE-1820: Allow newlines within key events. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
reviewed
Aug 30, 2023
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
mike-jumper
requested changes
Aug 30, 2023
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
3 times, most recently
from
7533f0b
to
f26d272
Compare
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
from
f26d272
to
3ccb464
Compare
mike-jumper
requested changes
Sep 27, 2023
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
from
3ccb464
to
ed51db6
Compare
mike-jumper
requested changes
Sep 27, 2023
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
from
ed51db6
to
d2bf8eb
Compare
mike-jumper
reviewed
Sep 27, 2023
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
2 times, most recently
from
46a8e5a
to
3d8ced2
Compare
mike-jumper
approved these changes
Sep 27, 2023
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
from
3d8ced2
to
f52ef6c
Compare
mike-jumper
requested changes
Sep 27, 2023
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
from
f52ef6c
to
39fa2fd
Compare
mike-jumper
approved these changes
Sep 27, 2023
…cific code to the webapp.
jmuehlner
force-pushed
the
GUACAMOLE-1820-allow-word-wrap-within-key-event
branch
from
39fa2fd
to
e3a249d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that newlines are rendered within individual key events.
This ensures that, for example, if you type several commands into a terminal, pressing enter after each command, these commands will render on subsequent lines in the key event viewer, rather than being compressed all into a single line.