HADOOP-19299. HttpReferrerAuditHeader resilience

style checks + extra javadocs Change-Id: I1fbe381c49f51f9f4df62fd674a693c89ce9e9ed
apache · Oct 3, 2024 · 0be63c1 · 0be63c1
1 parent 99cda77
commit 0be63c1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/...hadoop-common/src/main/java/org/apache/hadoop/fs/store/audit/HttpReferrerAuditHeader.java b/...hadoop-common/src/main/java/org/apache/hadoop/fs/store/audit/HttpReferrerAuditHeader.java
@@ -63,6 +63,9 @@
  * This header may be shared across multiple threads at the same time.
  * so some methods are marked as synchronized, specifically those reading
  * or writing the attribute map.
+ * <p>
+ * For the same reason, maps and lists passed down during construction are
+ * copied into thread safe structures.
  */
 @InterfaceAudience.Private
 @InterfaceStability.Unstable
@@ -203,7 +206,7 @@ public synchronized String buildHttpReferrer() {
     } catch (RuntimeException e) {
       // do not let failure to build the header stop the request being
       // issued.
-      LOG.warn("Failed to construct referred header " + e , e);
+      LOG.warn("Failed to construct referred header {}", e.toString(), e);
       LOG.debug("Full stack", e);
       header = "";
     }

diff --git a/.../hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestHttpReferrerAuditHeader.java b/.../hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestHttpReferrerAuditHeader.java
@@ -439,4 +439,4 @@ public void testSpanResilience() throws Throwable {
       auditContext.remove(failing);
     }
   }
-}
+}
diff --git a/...tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/impl/ReferrerExtractor.java b/...tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/impl/ReferrerExtractor.java
@@ -27,6 +27,9 @@
  */
 public final class ReferrerExtractor {
 
+  private ReferrerExtractor() {
+  }
+
   /**
    * Get the referrer provided the span is an instance or
    * subclass of LoggingAuditSpan.
-Original file line number
+Diff line change
@@ Expand Up / @@ -439,4 +439,4 @@ public void testSpanResilience() throws Throwable { @@
           auditContext.remove(failing);
         }
       }
-    }
+    }