HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. [branch-3.3] #6105

saxenapranav · 2023-09-21T04:38:12Z

JIRA: https://issues.apache.org/jira/browse/HADOOP-18873
Trunk PR: #6010
Commit cherrypicked from trunk: f24b73e

:::: AGGREGATED TEST RESULT ::::

HNS-OAuth

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 141, Failures: 1, Errors: 0, Skipped: 5
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] ITestAzureBlobFileSystemLease.testAcquireRetry:336 » TestTimedOut test timed o...
[INFO]
[ERROR] Tests run: 588, Failures: 0, Errors: 1, Skipped: 54
[INFO] Results:
[INFO]
[WARNING] Tests run: 339, Failures: 0, Errors: 0, Skipped: 41

HNS-SharedKey

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 141, Failures: 1, Errors: 0, Skipped: 5
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] ITestAzureBlobFileSystemLease.testAcquireRetry:336 » TestTimedOut test timed o...
[INFO]
[ERROR] Tests run: 588, Failures: 0, Errors: 1, Skipped: 54
[INFO] Results:
[INFO]
[WARNING] Tests run: 339, Failures: 0, Errors: 0, Skipped: 41

NonHNS-SharedKey

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 141, Failures: 1, Errors: 0, Skipped: 11
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ITestAzureBlobFileSystemRandomRead.testSkipBounds:218->Assert.assertTrue:42->Assert.fail:89 There should not be any network I/O (elapsedTimeMs=25).
[ERROR] Errors:
[ERROR] ITestAzureBlobFileSystemLease.testAcquireRetry:344->lambda$testAcquireRetry$6:345 » TestTimedOut
[INFO]
[ERROR] Tests run: 588, Failures: 1, Errors: 1, Skipped: 277
[INFO] Results:
[INFO]
[WARNING] Tests run: 339, Failures: 0, Errors: 0, Skipped: 44

AppendBlob-HNS-OAuth

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAccountConfiguration.testConfigPropNotFound:386->testMissingConfigKey:399 Expected a org.apache.hadoop.fs.azurebfs.contracts.exceptions.TokenAccessProviderException to be thrown, but got the result: : "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider"
[INFO]
[ERROR] Tests run: 141, Failures: 1, Errors: 0, Skipped: 5
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ITestAzureBlobFileSystemRandomRead.testValidateSeekBounds:269->Assert.assertTrue:42->Assert.fail:89 There should not be any network I/O (elapsedTimeMs=113).
[ERROR] Errors:
[ERROR] ITestAzureBlobFileSystemLease.testAcquireRetry:344->lambda$testAcquireRetry$6:345 » TestTimedOut
[INFO]
[ERROR] Tests run: 588, Failures: 1, Errors: 1, Skipped: 54
[INFO] Results:
[INFO]
[WARNING] Tests run: 339, Failures: 0, Errors: 0, Skipped: 41

Time taken: 45 mins 16 secs.
azureuser@Hadoop-VM-EAST2:~/hadoop/hadoop-tools/hadoop-azure$ git log
commit 3f87cc5 (HEAD -> branch-3.3_HADOOP-18873, origin/branch-3.3_HADOOP-18873)
Author: Pranav Saxena 108325433+saxenapranav@users.noreply.github.com
Date: Wed Sep 20 01:54:36 2023 -0700

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. (#6010)


AbfsOutputStream to close the dataBlock object created for the upload.

Contributed By: Pranav Saxena

…pache#6010) AbfsOutputStream to close the dataBlock object created for the upload. Contributed By: Pranav Saxena

hadoop-yetus · 2023-09-21T08:33:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 12s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	13m 35s		Maven dependency ordering for branch
-1 ❌	mvninstall	37m 56s	/branch-mvninstall-root.txt	root in branch-3.3 failed.
+1 💚	compile	20m 17s		branch-3.3 passed
+1 💚	checkstyle	2m 45s		branch-3.3 passed
+1 💚	mvnsite	2m 43s		branch-3.3 passed
+1 💚	javadoc	1m 41s		branch-3.3 passed
+1 💚	spotbugs	3m 55s		branch-3.3 passed
-1 ❌	shadedclient	39m 2s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 41s		the patch passed
+1 💚	compile	19m 13s		the patch passed
+1 💚	javac	19m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 46s		the patch passed
+1 💚	mvnsite	2m 49s		the patch passed
+1 💚	javadoc	1m 46s		the patch passed
+1 💚	spotbugs	4m 23s		the patch passed
-1 ❌	shadedclient	38m 30s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 31s		hadoop-common in the patch passed.
+1 💚	unit	2m 29s		hadoop-azure in the patch passed.
+1 💚	asflicense	1m 8s		The patch does not generate ASF License warnings.
		233m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6105/1/artifact/out/Dockerfile
GITHUB PR	#6105
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 6557821a6162 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `3f87cc5`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6105/1/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6105/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

mehakmeet

+1, yetus failures unrelated.

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. (a…

3f87cc5

…pache#6010) AbfsOutputStream to close the dataBlock object created for the upload. Contributed By: Pranav Saxena

saxenapranav mentioned this pull request Sep 21, 2023

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. #6010

Merged

mehakmeet approved these changes Sep 25, 2023

View reviewed changes

mehakmeet merged commit a3e132e into apache:branch-3.3 Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. [branch-3.3] #6105

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. [branch-3.3] #6105

Uh oh!

saxenapranav commented Sep 21, 2023

Uh oh!

hadoop-yetus commented Sep 21, 2023

Uh oh!

mehakmeet left a comment

Uh oh!

Uh oh!

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. [branch-3.3] #6105

HADOOP-18873. ABFS: AbfsOutputStream doesnt close DataBlocks object. [branch-3.3] #6105

Uh oh!

Conversation

saxenapranav commented Sep 21, 2023

HNS-OAuth

HNS-SharedKey

NonHNS-SharedKey

AppendBlob-HNS-OAuth

Uh oh!

hadoop-yetus commented Sep 21, 2023

Uh oh!

mehakmeet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!