HDFS-17242. Make congestion backoff time configurable. #6227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn @Hexiaoqiao Hi, sir. Could you please help me review this PR when you have free time? Thanks a lot! |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Oct 29, 2023
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
Outdated
Show resolved
Hide resolved
|
|
💔 -1 overall
This message was automatically generated. |
hfutatzhanghb
force-pushed
the
HDFS-17242
branch
from
1879a20 to
6fdcaee
Compare
|
💔 -1 overall
This message was automatically generated. |
tomscut
reviewed
Oct 31, 2023
...ect/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
Outdated
Show resolved
Hide resolved
hfutatzhanghb
force-pushed
the
HDFS-17242
branch
from
9dd1e2a to
cdd90fe
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed UT was passed in my local. |
|
@ayushtkn Hi, Sir. Have fixed some problems. Could you please review this pr again when you have free time? Thanks a lot. |
ayushtkn
approved these changes
Dec 1, 2023
Comment on lines
+573
to
+589
| if (congestionBackOffMeanTimeInMs <= 0 || congestionBackOffMaxTimeInMs <= 0 || | ||
| congestionBackOffMaxTimeInMs < congestionBackOffMeanTimeInMs) { |
There was a problem hiding this comment.
I don't think we need to have a redundant wrapping if condition, we can directly go to if statements & change to defaults post checking the condition in the same if block
There was a problem hiding this comment.
Sorry, sir. I can not get you here. Do you mean remove if (congestionBackOffMeanTimeInMs <= 0) and LOG.warn right?
There was a problem hiding this comment.
I mean no need to have parent if check
if (congestionBackOffMeanTimeInMs <= 0 || congestionBackOffMaxTimeInMs <= 0 ||
congestionBackOffMaxTimeInMs < congestionBackOffMeanTimeInMs) {
We can have all three individual if checks
There was a problem hiding this comment.
Got it. Have fixed it. Thanks a lot Sir.
There was a problem hiding this comment.
this looks a bit weird to me. Isn't the following cleaner?
if (meanTime <= 0) {
log.WARN("mean time invalid. use default");
meanTime = meanTimeDefault;
}
if (maxTime <= 0) {
log.WARN("max time invalid. use default");
maxTime = maxTimeDefault;
}
if (meanTime > maxTime) {
log.WARN("mean/max time invalid. use default for both");
meanTime = meanTimeDefault;
maxTime = maxTimeDefault;
}
| <name>dfs.client.congestion.backoff.mean.time</name> | ||
| <value>5000</value> | ||
| <description> | ||
| The mean milliseconds which is used to compute client congestion backoff sleep time. |
There was a problem hiding this comment.
The mean time in milliseconds which is used to compute client congestion backoff sleep time.
There was a problem hiding this comment.
Thanks sir, have fixed.
| <name>dfs.client.congestion.backoff.max.time</name> | ||
| <value>50000</value> | ||
| <description> | ||
| The max milliseconds which is used to |
There was a problem hiding this comment.
The max time in milliseconds which is used to restrict the upper limit backoff sleep time for client.
There was a problem hiding this comment.
Thanks sir, have fixed.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn Sir, could you please help me push this PR forward? Thanks a lot. |
hfutatzhanghb
force-pushed
the
HDFS-17242
branch
from
138ace4 to
efefa15
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @hfutatzhanghb for your contribution! Thanks @ayushtkn and @xinglin for the review! |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Reviewed-by: Xing Lin <xinglin@linkedin.com> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Signed-off-by: Tao Li <tomscut@apache.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently，if we enable congestion backoff, we will actually invoke backOffIfNecessary method. and the backoff time is computed using CONGESTION_BACKOFF_MEAN_TIME_IN_MS and CONGESTION_BACK_OFF_MAX_TIME_IN_MS which are hard-code. We should better make them configurable to compute backoff sleep time flexibly.