HDFS-17337. RPC RESPONSE time seems not exactly accurate when using FSEditLogAsync. #6439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Refer to HDFS-17337.
Currently, FSEditLogAsync is enabled by default.
We have below codes in method Server$RpcCall#run:
It computes Timing.RESPONSE of a RpcCall using Time.monotonicNowNanos() - startNanos;
However, if we use async editlogging, we will not send response here but in FSEditLogAsync.RpcEdit#logSyncNotify.
This causes the Timing.RESPONSE of a RpcCall not be exactly accurate.
flame graph like below:
