HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6537

slfan1989 · 2024-02-08T03:19:56Z

Description of PR

JIRA: HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5.

I upgraded locally and tested the compilation. The compilation result showed success.

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-02-08T04:20:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 8s		trunk passed
+1 💚	compile	0m 14s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 14s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	0m 16s		trunk passed
+1 💚	javadoc	0m 19s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 15s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	53m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 9s		the patch passed
+1 💚	compile	0m 8s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 8s		the patch passed
+1 💚	compile	0m 10s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 11s		the patch passed
+1 💚	javadoc	0m 9s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 11s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 ❌	shadedclient	1m 34s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 9s		hadoop-project in the patch passed.
+1 💚	asflicense	0m 19s		The patch does not generate ASF License warnings.
		59m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/1/artifact/out/Dockerfile
GITHUB PR	#6537
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux bf22f2dfefeb 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9d0c44e`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/1/testReport/
Max. process+thread count	551 (vs. ulimit of 5500)
modules	C: hadoop-project U: hadoop-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-02-08T05:49:57Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/2/console in case of problems.

hadoop-yetus · 2024-02-08T07:03:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 29s		trunk passed
+1 💚	compile	0m 14s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 13s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	0m 16s		trunk passed
+1 💚	javadoc	0m 17s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 14s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	19m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 10s		the patch passed
+1 💚	compile	0m 8s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 8s		the patch passed
+1 💚	compile	0m 8s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 8s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	mvnsite	0m 12s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	javadoc	0m 9s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 11s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	19m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 11s		hadoop-project in the patch passed.
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		75m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/2/artifact/out/Dockerfile
GITHUB PR	#6537
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient xmllint
uname	Linux 4bbfeceb9378 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a76f77e`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/2/testReport/
Max. process+thread count	558 (vs. ulimit of 5500)
modules	C: hadoop-project U: hadoop-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2024-02-08T11:22:56Z

@steveloughran Can you help review this PR? Thank you very much! It looks like we can directly upgrade maven-surefire-plugin to 3.2.2.

sjlee · 2024-02-08T18:05:33Z

Out of curiosity, what was the reason to pick 3.2.2 as the version to upgrade? The latest version seems to be 3.2.5 and there seem to be quite a few fixes between these two versions.

steveloughran

+1 from me; let's what surprises surface

slfan1989 · 2024-02-08T23:11:29Z

@sjlee @steveloughran Thank you for your attention to this PR! When I chose this version, I checked the dependencies of the Spark and Flink projects. As of now, Spark is using 3.1.2, and Flink is using 3.2.2, so I opted for 3.2.2. However, we can consider trying 3.2.5. I will proceed to test it immediately.

hadoop-yetus · 2024-02-08T23:15:57Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/3/console in case of problems.

hadoop-yetus · 2024-02-09T00:28:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 23s		trunk passed
+1 💚	compile	0m 13s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 12s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	0m 18s		trunk passed
+1 💚	javadoc	0m 20s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 15s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	19m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 9s		the patch passed
+1 💚	compile	0m 10s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 10s		the patch passed
+1 💚	compile	0m 9s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 9s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 12s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	javadoc	0m 10s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 10s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	19m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 11s		hadoop-project in the patch passed.
+1 💚	asflicense	0m 23s		The patch does not generate ASF License warnings.
		75m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/3/artifact/out/Dockerfile
GITHUB PR	#6537
Optional Tests	dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient xmllint
uname	Linux 8574d6e96e29 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bc34daa`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/3/testReport/
Max. process+thread count	729 (vs. ulimit of 5500)
modules	C: hadoop-project U: hadoop-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6537/3/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

+1 for the change on trunk/3.4; let's see what surprises surface...we only need to worry about build time issues, not production ones.

slfan1989 · 2024-02-09T23:42:10Z

+1 for the change on trunk/3.4; let's see what surprises surface...we only need to worry about build time issues, not production ones.

I will submit a pull request to trunk3.4 and hopefully everything goes smoothly.

slfan1989 · 2024-02-10T23:41:15Z

@steveloughran Thank you for reviewing the code! I will merge this PR into the trunk branch and continue to progress with the work to support Java 17 compilation.

…5. (apache#6537) Contributed by Shilun Fan" This reverts commit 555faf2.

shahrs87 · 2024-02-20T19:30:13Z

Hi @slfan1989 @steveloughran
I am seeing test failures in TestCacheDirectives, TestBlockReportLease in the daily build after this PR.
First build after merging this PR here
Now trunk branch has become unstable and tests are failing with OOM and/or build getting stuck for days.
Sample builds:
Build 1
Build 2
Build 3
All the above builds are from different jiras but the same set of tests failing.
Can you please take a look and revert if needed? Thank you !

steveloughran · 2024-02-21T12:28:31Z

This is not good.

But looking at the failures I don't know whether to categorise as "test runner regression" or "brittle tests failing under new test runner".

Here are some of the ones I've looked at

TestDirectoryScanner.testThrottling
This test is measuring how long things took. it is way too brittle against timing changes, both slower and faster.

java.lang.AssertionError: Throttle is too permissive
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner.testThrottling(TestDirectoryScanner.java:901)

I think the step here is to move to assertj so asserts fail with meaningful messages, see if the failure can be understood. Ideally you'd want a test which doesn't measure elapsed time, but instead uses counters in the code (here: of throttle events) to assert what took place.

Test TestBlockListAsLongs.testFuzz

See this painfully often else where -it means that the protobuf lib was built with a more recent version of java8 than the early oracle ones. Its fixable in your own build (use the older one) or cast ByteBuffer to Buffer. otherwise we need to make sure tests are on a more recent build.

java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
	at org.apache.hadoop.thirdparty.protobuf.IterableByteBufferInputStream.read(IterableByteBufferInputStream.java:143)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.read(CodedInputStream.java:2080)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.tryRefillBuffer(CodedInputStream.java:2831)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.refillBuffer(CodedInputStream.java:2777)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.readRawByte(CodedInputStream.java:2859)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.readRawVarint64SlowPath(CodedInputStream.java:2648)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.readRawVarint64(CodedInputStream.java:2641)
	at org.apache.hadoop.thirdparty.protobuf.CodedInputStream$StreamDecoder.readSInt64(CodedInputStream.java:2497)
	at org.apache.hadoop.hdfs.protocol.BlockListAsLongs$BufferDecoder$1.next(BlockListAsLongs.java:419)
	at org.apache.hadoop.hdfs.protocol.BlockListAsLongs$BufferDecoder$1.next(BlockListAsLongs.java:397)
	at org.apache.hadoop.hdfs.protocol.BlockListAsLongs$BufferDecoder.getBlockListAsLongs(BlockListAsLongs.java:375)
	at org.apache.hadoop.hdfs.protocol.TestBlockListAsLongs.checkReport(TestBlockListAsLongs.java:156)
	at org.apache.hadoop.hdfs.protocol.TestBlockListAsLongs.testFuzz(TestBlockListAsLongs.java:139)

test TestDFSAdmin.testDecommissionDataNodesReconfig

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.hadoop.hdfs.tools.TestDFSAdmin.testDecommissionDataNodesReconfig(TestDFSAdmin.java:1356)

not a very meaningful message. suspect that a different ordering of the threads is causing the assert to fail.

move to AssertJ
analyse error, see what the fix is.

Test TestCacheDirectives.

at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:403)
	at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:362)
	at org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.waitForCachedBlocks(TestCacheDirectives.java:760)
	at org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.teardown(TestCacheDirectives.java:173)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

this is a timeout during teardown; after this subsequent tests are possibly going to fail. No obvious cause, though again I'd suspect race conditions.

Rather than say "hey, let's revert", I'd propose a "surefire update triggers test failures" and see what can be done about addressing them. because we can't stay frozen with surefire versions.

ayushtkn · 2024-02-21T12:36:25Z

Some tests are getting skipped as well as I mentioned on the jira
https://issues.apache.org/jira/browse/HADOOP-19071?focusedCommentId=17818734&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17818734

TestDirectoryScanner is a known flaky that ain’t related there is already a ticket somewhere

ayushtkn · 2024-02-21T12:38:51Z

& some are failing due to protobuf upgrade as part of hadoop thirdparty upgrade, I am checking all the HDFS tests, but little slowly
https://issues.apache.org/jira/browse/HADOOP-18197?focusedCommentId=17818651&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17818651

i will create a ticket and link some related ones or so

shahrs87 · 2024-02-21T17:25:46Z

Thank you @steveloughran for your response.

Rather than say "hey, let's revert", I'd propose a "surefire update triggers test failures" and see what can be done about addressing them. because we can't stay frozen with surefire versions.

I didn't mean to sound rude. Apologies if you felt that way. I understand that when upgrading maven, surefire or protobuf's version, it is very reasonable to see test failures. But in this case, the jenkins build is not running all tests, some of the tests are failing and some of the builds are getting stuck for 20-24 hours and is affecting all the developers. I spent atleast 2-3 days debugging the test failures assuming that this is caused by my patch before posting a message on the slack channel and then @ayushtkn helped me. I am sure other developers have followed the same path.
What I am suggesting is: Lets revert this change, unblock all developers and then we raise a new PR with the proposed surefire version change, make sure all the tests pass, make test improvements if needed and then push the change to trunk branch.
WDYT?
Cc @ayushtkn @slfan1989

slfan1989 · 2024-02-22T14:17:45Z

@shahrs87 I agree to revert this PR. I've noticed several PRs failing to compile, which is concerning.

I will continue to follow up on updating the maven-surefire-plugin; indeed, this requires more testing.

cc: @steveloughran @ayushtkn

slfan1989 · 2024-02-22T14:30:52Z

I have carefully read the comments above. Some unit tests reported errors. We need to re-modify the unit tests. I will actively participate in the modification of this part.

cc: @steveloughran @ayushtkn

tasanuma · 2024-02-22T15:33:08Z

There is another problem. After this PR, running any unit test using mvn test from the command line has always resulted in a failure.

$ mvn test -Dtest=TestCacheDirectives
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.2.5:test (default-test) on project hadoop-annotations: No tests matching pattern "TestCacheDirectives" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]

ayushtkn · 2024-02-22T15:38:52Z

@tasanuma that problem is there even before this, I had a ticket: HADOOP-18701, and was trying to handle that along with several other stuff, now I don't remember why I left it :-)

slfan1989 · 2024-02-23T06:12:34Z

@ayushtkn @tasanuma @steveloughran

I don't want to roll back this change. I would like to continue pushing for this upgrade. I have noticed several pull requests that seem to compile inaccurately.

Nevertheless, I have decided to roll back this change for now to minimize the impact on other members.

I'm working on fixing HADOOP-15984 and I'll follow up later with HADOOP-19071.

#6567
https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6567/1/pipeline/

#6559
https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6559/3/pipeline/

#6526

Wed Feb 21 18:33:30 UTC 2024
cd /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-6526/centos-7/src
/opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-6526/yetus-m2/hadoop-trunk-patch-1 -DskipTests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true
Error occurred during initialization of VM
Cannot create VM thread. Out of system resources.

…5. (#6537)" (#6578) This reverts commit 555faf2.

slfan1989 · 2024-02-23T06:27:40Z

@shahrs87 I rolled back #6537. If you have any questions, feel free to contact me.

steveloughran · 2024-02-23T15:49:40Z

pity. I do think those failures need to be addressed, as they are less test runner problems than brittle tests which will need to be fixed eventually

…5. (#6537)" (#6578) This reverts commit 555faf2.

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.2.

9d0c44e

github-actions bot added build trunk labels Feb 8, 2024

HADOOP-19071. Fix shadedclient Test Error.

a76f77e

github-actions bot added the Infra label Feb 8, 2024

steveloughran approved these changes Feb 8, 2024

View reviewed changes

HADOOP-19071. Use 3.2.5.

bc34daa

steveloughran approved these changes Feb 9, 2024

View reviewed changes

steveloughran changed the title ~~HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.2.~~ HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. Feb 9, 2024

slfan1989 merged commit 555faf2 into apache:trunk Feb 10, 2024
1 of 3 checks passed

ritegarg pushed a commit to ritegarg/hadoop that referenced this pull request Feb 20, 2024

Revert "HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.…

b927546

…5. (apache#6537) Contributed by Shilun Fan" This reverts commit 555faf2.

ritegarg pushed a commit to ritegarg/hadoop that referenced this pull request Feb 20, 2024

Revert "HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.…

6728e40

…5. (apache#6537) Contributed by Shilun Fan" This reverts commit 555faf2.

slfan1989 mentioned this pull request Feb 23, 2024

Revert "HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5." #6578

Merged

slfan1989 added a commit that referenced this pull request Feb 23, 2024

Revert "HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.…

10ab8ab

…5. (#6537)" (#6578) This reverts commit 555faf2.

slfan1989 mentioned this pull request Feb 29, 2024

HDFS-17387. [FGL] Abstract the configuration locking mode #6572

Merged

slfan1989 added a commit that referenced this pull request Feb 29, 2024

Revert "HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.…

f42e4ca

…5. (#6537)" (#6578) This reverts commit 555faf2.

steveloughran mentioned this pull request Mar 1, 2024

Commit to remove vulnerabilities raised for: HADOOP-19074 #6586

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6537

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6537

slfan1989 commented Feb 8, 2024 •

edited

Loading

hadoop-yetus commented Feb 8, 2024

hadoop-yetus commented Feb 8, 2024

hadoop-yetus commented Feb 8, 2024

slfan1989 commented Feb 8, 2024

sjlee commented Feb 8, 2024

steveloughran left a comment

slfan1989 commented Feb 8, 2024

hadoop-yetus commented Feb 8, 2024

hadoop-yetus commented Feb 9, 2024

steveloughran left a comment

slfan1989 commented Feb 9, 2024

slfan1989 commented Feb 10, 2024

shahrs87 commented Feb 20, 2024

steveloughran commented Feb 21, 2024

ayushtkn commented Feb 21, 2024

ayushtkn commented Feb 21, 2024 •

edited

Loading

shahrs87 commented Feb 21, 2024 •

edited

Loading

slfan1989 commented Feb 22, 2024

slfan1989 commented Feb 22, 2024

tasanuma commented Feb 22, 2024

ayushtkn commented Feb 22, 2024

slfan1989 commented Feb 23, 2024 •

edited

Loading

slfan1989 commented Feb 23, 2024

steveloughran commented Feb 23, 2024

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6537

HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6537

Conversation

slfan1989 commented Feb 8, 2024 • edited Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Feb 8, 2024

hadoop-yetus commented Feb 8, 2024

hadoop-yetus commented Feb 8, 2024

slfan1989 commented Feb 8, 2024

sjlee commented Feb 8, 2024

steveloughran left a comment

Choose a reason for hiding this comment

slfan1989 commented Feb 8, 2024

hadoop-yetus commented Feb 8, 2024

hadoop-yetus commented Feb 9, 2024

steveloughran left a comment

Choose a reason for hiding this comment

slfan1989 commented Feb 9, 2024

slfan1989 commented Feb 10, 2024

shahrs87 commented Feb 20, 2024

steveloughran commented Feb 21, 2024

ayushtkn commented Feb 21, 2024

ayushtkn commented Feb 21, 2024 • edited Loading

shahrs87 commented Feb 21, 2024 • edited Loading

slfan1989 commented Feb 22, 2024

slfan1989 commented Feb 22, 2024

tasanuma commented Feb 22, 2024

ayushtkn commented Feb 22, 2024

slfan1989 commented Feb 23, 2024 • edited Loading

slfan1989 commented Feb 23, 2024

steveloughran commented Feb 23, 2024

slfan1989 commented Feb 8, 2024 •

edited

Loading

ayushtkn commented Feb 21, 2024 •

edited

Loading

shahrs87 commented Feb 21, 2024 •

edited

Loading

slfan1989 commented Feb 23, 2024 •

edited

Loading