YARN-11657. Remove protobuf-2.5 as dependency of hadoop-yarn modules #6575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Idf21777dabd10910404669310a94d92cab78c700
|
doing a build shows it is still coming in to timeline service. that's because it is talking to hbase...to fix that we'd need to move to an hbase client which was more current. Issue: should we explicitly list it in LICENSE-binary? |
|
comes in because of |
-reinstate protobuf as an artifact -noted that the jsch version was outdated and updated that too Change-Id: I7a77f616c01b6611bfacbf5ea1e8834ef5113bb4
Updated building docs. Change-Id: I50b755d129fa0a7841edb787f430a48ddb3e8cf1
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Feb 22, 2024
ayushtkn
reviewed
Feb 23, 2024
| @@ -72,6 +72,7 @@ | |||
| <dependency> | |||
| <groupId>com.google.protobuf</groupId> | |||
| <artifactId>protobuf-java</artifactId> | |||
| <scope>${transient.protobuf2.scope}</scope> | |||
There was a problem hiding this comment.
Any pointers why are we putting scope in every declarition rather than just putting it up in the parent pom?
c373d3f
There was a problem hiding this comment.
- The dependent poms (hadoop-common...) aren't publishing it any more, just using it for compilation.
- I don't trust the base declaration to do the right thing.
|
💔 -1 overall
This message was automatically generated. |
|
I don't want to backport this to 3.4.0; i'm going to merge into branch-3.4 and trunk but not 3.4.0 as the lib is still needed in one place and there's a risk of breaking things. |
|
pushed up a change which updates the building doc |
4 tasks
steveloughran
added a commit
to steveloughran/hadoop
that referenced
this pull request
Feb 23, 2024
) The import of protobuf-java-2.5 in the hadoop-yarn-api module is downgraded from "compile" to "provided" This removes it from share/hadoop/yarn/lib/protobuf-java-2.5.0.jar It is still found under share/hadoop/yarn/timelineservice/lib/protobuf-java-2.5.0.jar Change-Id: Id90019ccf6401072c90c50bb25c9924ad0385fba
steveloughran
added a commit
to steveloughran/hadoop
that referenced
this pull request
Feb 23, 2024
) The import of protobuf-java-2.5 in the hadoop-yarn-api module is downgraded from "compile" to "provided" This removes it from share/hadoop/yarn/lib/protobuf-java-2.5.0.jar It is still found under share/hadoop/yarn/timelineservice/lib/protobuf-java-2.5.0.jar Change-Id: I89b00f0ddff29af4bfb3173ef7cbd8ba4563d3ef
4 tasks
|
💔 -1 overall
This message was automatically generated. |
steveloughran
added a commit
that referenced
this pull request
Mar 5, 2024
…6580) The import of protobuf-java-2.5 in the hadoop-yarn-api module is downgraded from "compile" to "provided" This removes it from share/hadoop/yarn/lib/protobuf-java-2.5.0.jar It is still found under share/hadoop/yarn/timelineservice/lib/protobuf-java-2.5.0.jar Contributed by Steve Loughran
steveloughran
added a commit
that referenced
this pull request
Mar 5, 2024
…6581) The import of protobuf-java-2.5 in the hadoop-yarn-api module is downgraded from "compile" to "provided" This removes it from share/hadoop/yarn/lib/protobuf-java-2.5.0.jar It is still found under share/hadoop/yarn/timelineservice/lib/protobuf-java-2.5.0.jar Contributed by Steve Loughran
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this patch tested?
hadoop release support verifies that protobuf-2.5 isn't published as a dependency of
any artifact.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?