HADOOP-19270 Use stable sort in commandQueue #7038

geatrigger · 2024-09-11T04:16:13Z

Description of PR

JIRA: HADOOP-19270 Use stable sort in commandQueue

To remove possibility of wrong-ordered log simulation

How was this patch tested?

Tested using real production hadoop cluster(PB size cluster, create 256MB hdfs-audit.log per 10 minutes) hdfs-audit.log files.
Stable sort shows similar latency results while unstable sort(before patched) shows unstable latency results.
- Total latency should be similar because all test simulate same amount of hdfs-audit logs
- But unstable sort results show unstable total latency because when simulate logs faster(increasing rate), same timestamp log increases, results wrong order simulating in unstable sort.
For detail, see https://issues.apache.org/jira/browse/HADOOP-19270

For code changes: Add sequence to commandQueue sorting criteria

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-09-11T05:42:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	6m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 7s		trunk passed
+1 💚	compile	0m 15s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 15s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 18s		trunk passed
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	javadoc	0m 24s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 18s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 33s		trunk passed
+1 💚	shadedclient	20m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 12s	/patch-mvninstall-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	hadoop-dynamometer-workload in the patch failed.
-1 ❌	compile	0m 12s	/patch-compile-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-dynamometer-workload in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌	javac	0m 12s	/patch-compile-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-dynamometer-workload in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌	compile	0m 12s	/patch-compile-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-dynamometer-workload in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
-1 ❌	javac	0m 12s	/patch-compile-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-dynamometer-workload in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 10s	/buildtool-patch-checkstyle-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	The patch fails to run checkstyle in hadoop-dynamometer-workload
-1 ❌	mvnsite	0m 14s	/patch-mvnsite-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	hadoop-dynamometer-workload in the patch failed.
-1 ❌	javadoc	0m 13s	/results-javadoc-javadoc-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
-1 ❌	javadoc	0m 14s	/results-javadoc-javadoc-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkPrivateBuild-1.8.0_422-8u422-b05-1~~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~~20.04-b05 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
-1 ❌	spotbugs	0m 12s	/patch-spotbugs-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	hadoop-dynamometer-workload in the patch failed.
+1 💚	shadedclient	21m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 14s	/patch-unit-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	hadoop-dynamometer-workload in the patch failed.
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		85m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/1/artifact/out/Dockerfile
GITHUB PR	#7038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ae8ff81738e6 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8ff840b`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/1/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-09-11T11:21:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	49m 37s		trunk passed
+1 💚	compile	0m 28s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 26s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 25s		trunk passed
+1 💚	mvnsite	0m 28s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 25s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 43s		trunk passed
+1 💚	shadedclient	39m 19s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	0m 18s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 18s		the patch passed
+1 💚	compile	0m 16s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 16s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 13s	/results-checkstyle-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	mvnsite	0m 19s		the patch passed
-1 ❌	javadoc	0m 19s	/results-javadoc-javadoc-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
-1 ❌	javadoc	0m 18s	/results-javadoc-javadoc-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload-jdkPrivateBuild-1.8.0_422-8u422-b05-1~~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~~20.04-b05 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
-1 ❌	spotbugs	0m 45s	/new-spotbugs-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.html	hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	39m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 56s		hadoop-dynamometer-workload in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		157m 5s

Reason	Tests
SpotBugs	module:hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload
	Suspicious comparison of Long references in org.apache.hadoop.tools.dynamometer.workloadgenerator.audit.AuditReplayCommand.equals(Object) At AuditReplayCommand.java:in org.apache.hadoop.tools.dynamometer.workloadgenerator.audit.AuditReplayCommand.equals(Object) At AuditReplayCommand.java:[line 156]

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/2/artifact/out/Dockerfile
GITHUB PR	#7038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux bd9768d848ae 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `02d211b`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/2/testReport/
Max. process+thread count	549 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-09-12T08:22:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 16s		trunk passed
+1 💚	compile	0m 19s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 16s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 17s		trunk passed
+1 💚	mvnsite	0m 22s		trunk passed
+1 💚	javadoc	0m 23s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 19s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 31s		trunk passed
+1 💚	shadedclient	20m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s		the patch passed
+1 💚	compile	0m 13s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 13s		the patch passed
+1 💚	compile	0m 13s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 9s		the patch passed
+1 💚	mvnsite	0m 14s		the patch passed
+1 💚	javadoc	0m 13s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 14s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 29s		the patch passed
+1 💚	shadedclient	19m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 46s	/patch-unit-hadoop-tools_hadoop-dynamometer_hadoop-dynamometer-workload.txt	hadoop-dynamometer-workload in the patch passed.
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		87m 8s

Reason	Tests
Failed junit tests	hadoop.tools.dynamometer.workloadgenerator.audit.TestAuditLogDirectParser

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/3/artifact/out/Dockerfile
GITHUB PR	#7038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 63e1d3cc8167 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ee08dd7`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/3/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-09-19T08:23:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 36s		trunk passed
+1 💚	compile	0m 19s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 16s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 19s		trunk passed
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	javadoc	0m 23s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 20s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 32s		trunk passed
+1 💚	shadedclient	19m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s		the patch passed
+1 💚	compile	0m 12s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 12s		the patch passed
+1 💚	compile	0m 13s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 10s		the patch passed
+1 💚	mvnsite	0m 15s		the patch passed
+1 💚	javadoc	0m 12s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 13s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 31s		the patch passed
+1 💚	shadedclient	20m 20s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 48s		hadoop-dynamometer-workload in the patch passed.
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		80m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/4/artifact/out/Dockerfile
GITHUB PR	#7038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 72d44cf3dc06 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4fd8bf4`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/4/testReport/
Max. process+thread count	631 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

geatrigger · 2024-10-21T04:56:24Z

cc: @slfan1989 @adoroszlai

Hi, I tagged who recently reviewed another prs!
Please review and check this pr.

adoroszlai · 2024-10-21T06:19:11Z

Hi, I tagged who recently reviewed another prs!

Sorry, I cannot review, never worked on dynamometer. Please check git log of the files being changed for past authors/reviewers.

geatrigger · 2024-10-22T01:10:34Z

cc: @virajjasani @tasanuma
I tagged more who contribute to dynamometer!
Please review and check this pr.

geatrigger · 2025-02-26T01:40:52Z

cc: @xkrogen
I tagged more who contribute to dynamometer!
Please review and check this pr.

xkrogen · 2025-02-26T15:49:42Z

Hey @geatrigger , this looks like a great improvement. The code LGTM. Can you please rebase onto latest master and let's make sure the build is still passing?

nish4nthmurali · 2025-02-26T18:02:55Z

Hi guys new one to this community. would love to contribute and learn a lot.
seeking your help on this initial phase.

hadoop-yetus · 2025-02-27T00:07:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	23m 58s		trunk passed
+1 💚	compile	0m 19s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 16s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 19s		trunk passed
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 19s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 31s		trunk passed
+1 💚	shadedclient	19m 52s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s		the patch passed
+1 💚	compile	0m 12s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 12s		the patch passed
+1 💚	compile	0m 11s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 9s		the patch passed
+1 💚	mvnsite	0m 14s		the patch passed
+1 💚	javadoc	0m 14s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 12s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 30s		the patch passed
+1 💚	shadedclient	19m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 3s		hadoop-dynamometer-workload in the patch passed.
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		70m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/5/artifact/out/Dockerfile
GITHUB PR	#7038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 751baa8aaaaf 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bb51cba`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/5/testReport/
Max. process+thread count	555 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7038/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

geatrigger · 2025-02-27T00:25:05Z

@xkrogen
Thanks for quick reply!
I merged trunk(master of apache/hadoop) branch and verified that the build process completed successfully.

xkrogen · 2025-03-04T22:45:37Z

Merged to trunk. Thanks for your contribution @geatrigger !

github-actions bot added trunk TOOLS DYNAMOMETER labels Sep 11, 2024

geatrigger changed the title ~~Use stable sort in commandQueue~~ HADOOP-19270 Use stable sort in commandQueue Sep 11, 2024

Use stable sort in commandQueue

ee08dd7

geatrigger force-pushed the stable_sort branch from 02d211b to ee08dd7 Compare September 12, 2024 06:54

Add sequence in constructor

4fd8bf4

geatrigger marked this pull request as ready for review October 21, 2024 04:41

Merge branch 'apache:trunk' into stable_sort

bb51cba

xkrogen approved these changes Mar 4, 2025

View reviewed changes

xkrogen merged commit 103b054 into apache:trunk Mar 4, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19270 Use stable sort in commandQueue #7038

HADOOP-19270 Use stable sort in commandQueue #7038

geatrigger commented Sep 11, 2024 •

edited by slfan1989

Loading

hadoop-yetus commented Sep 11, 2024

hadoop-yetus commented Sep 11, 2024

hadoop-yetus commented Sep 12, 2024

hadoop-yetus commented Sep 19, 2024

geatrigger commented Oct 21, 2024

adoroszlai commented Oct 21, 2024 •

edited

Loading

geatrigger commented Oct 22, 2024

geatrigger commented Feb 26, 2025

xkrogen commented Feb 26, 2025

nish4nthmurali commented Feb 26, 2025 •

edited

Loading

hadoop-yetus commented Feb 27, 2025

geatrigger commented Feb 27, 2025

xkrogen commented Mar 4, 2025

HADOOP-19270 Use stable sort in commandQueue #7038

HADOOP-19270 Use stable sort in commandQueue #7038

Conversation

geatrigger commented Sep 11, 2024 • edited by slfan1989 Loading

Description of PR

How was this patch tested?

For code changes: Add sequence to commandQueue sorting criteria

hadoop-yetus commented Sep 11, 2024

hadoop-yetus commented Sep 11, 2024

hadoop-yetus commented Sep 12, 2024

hadoop-yetus commented Sep 19, 2024

geatrigger commented Oct 21, 2024

adoroszlai commented Oct 21, 2024 • edited Loading

geatrigger commented Oct 22, 2024

geatrigger commented Feb 26, 2025

xkrogen commented Feb 26, 2025

nish4nthmurali commented Feb 26, 2025 • edited Loading

hadoop-yetus commented Feb 27, 2025

geatrigger commented Feb 27, 2025

xkrogen commented Mar 4, 2025

geatrigger commented Sep 11, 2024 •

edited by slfan1989

Loading

adoroszlai commented Oct 21, 2024 •

edited

Loading

nish4nthmurali commented Feb 26, 2025 •

edited

Loading