Using FsUtils instead of Files API to extract file extension #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge in once Travis builds |
prazanna
approved these changes
Jun 29, 2017
|
Looking into the failures. |
n3nash
force-pushed
the
hoodieinstant_bug_fix
branch
from
9f671f1 to
f9ad1f8
Compare
|
@prazanna Can you take a look at the diff again ? I made some minor changes not sure if you got a chance to look at that before approving. |
prazanna
approved these changes
Jun 30, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #212